Rus
  1. HOME
  2. EXAMPLES OF ERRORS

Examples of errors detected by the V3115 diagnostic.


V3115. It is not recommended to throw exceptions from 'Equals(object obj)' method.

GitExtensions

V3115 Passing 'null' to 'Equals(object obj)' method should not result in 'NullReferenceException'. Git.hub Organization.cs 14


public override bool Equals(object obj)
{
  return GetHashCode() == obj.GetHashCode(); // <=
}

Similar errors can be found in some other places:

  • V3115 Passing 'null' to 'Equals(object obj)' method should not result in 'NullReferenceException'. Git.hub User.cs 16

Media Portal 2

V3115 Passing 'null' to 'Equals' method should not result in 'NullReferenceException'. EpisodeInfo.cs 561


public override bool Equals(object obj)
{
  EpisodeInfo other = obj as EpisodeInfo;
  if (obj == null) return false;
  if (TvdbId > 0 && other.TvdbId > 0)
    return TvdbId == other.TvdbId;
  ....
}

Instead of 'other' variable used 'obj' variable for 'null' checking.

PascalABC.NET

V3115 Passing 'null' to 'Equals' method should not result in 'NullReferenceException'. ICSharpCode.SharpDevelop ServiceReferenceMapFile.cs 31


public override bool Equals(object obj)
{
  var rhs = obj as ServiceReferenceMapFile;
  return FileName == rhs.FileName;
}

Do you make errors in the code?

Check your code
with PVS-Studio

Static code analysis
for C, C++, and C#

goto PVS-Studio;

Bugs Found

Checked Projects
295
Collected Errors
12 964

Qt

C++ 
int gx = gm.x.toInt();
int gy = gm.y.toInt();
int iw = gm.width.toInt();
int ih = gm.height.toInt();
if (iw <= 0 || iw <= 0)
  return 0;

UnrealEngine

C++ 
switch ( BlendMode )
{
case Opaque:
  BackgroundColor.A = 1.0f;
case Masked:
  BackgroundColor.A = 0.0f;
}

Xamarin

C# 
get {
  return Left == 0 &&
         Top == 0 &&
         Right == 0 &&
         Left == 0;
}

Chromium

C++ 
void Explode(bool is_local,
  Exploded* exploded) const
{
  ....
  ZeroMemory(
    exploded,
    sizeof(exploded));
  ....
}

Qt

C++ 
int gx = gm.x.toInt();
int gy = gm.y.toInt();
int iw = gm.width.toInt();
int ih = gm.height.toInt();
if (iw <= 0 || iw <= 0)
  return 0;

UnrealEngine

C++ 
switch ( BlendMode )
{
case Opaque:
  BackgroundColor.A = 1.0f;
case Masked:
  BackgroundColor.A = 0.0f;
}

Xamarin

C# 
get {
  return Left == 0 &&
         Top == 0 &&
         Right == 0 &&
         Left == 0;
}

Chromium

C++ 
void Explode(bool is_local,
  Exploded* exploded) const
{
  ....
  ZeroMemory(
    exploded,
    sizeof(exploded));
  ....
}
All projects →

Recent Posts

All articles →

It's interesting!