Examples of errors detected by the V3115 diagnostic.


V3115. It is not recommended to throw exceptions from 'Equals(object obj)' method.


GitExtensions

V3115 Passing 'null' to 'Equals(object obj)' method should not result in 'NullReferenceException'. Git.hub Organization.cs 14


public override bool Equals(object obj)
{
  return GetHashCode() == obj.GetHashCode(); // <=
}

Similar errors can be found in some other places:

  • V3115 Passing 'null' to 'Equals(object obj)' method should not result in 'NullReferenceException'. Git.hub User.cs 16

Media Portal 2

V3115 Passing 'null' to 'Equals' method should not result in 'NullReferenceException'. EpisodeInfo.cs 561


public override bool Equals(object obj)
{
  EpisodeInfo other = obj as EpisodeInfo;
  if (obj == null) return false;
  if (TvdbId > 0 && other.TvdbId > 0)
    return TvdbId == other.TvdbId;
  ....
}

Instead of 'other' variable used 'obj' variable for 'null' checking.


PascalABC.NET

V3115 Passing 'null' to 'Equals' method should not result in 'NullReferenceException'. ICSharpCode.SharpDevelop ServiceReferenceMapFile.cs 31


public override bool Equals(object obj)
{
  var rhs = obj as ServiceReferenceMapFile;
  return FileName == rhs.FileName;
}


Do you make errors in the code?

Check your code
with PVS-Studio

Static code analysis
for C, C++, and C#

goto PVS-Studio;
We use cookies for the analysis of events to improve our content and make user interaction more convenient. By continuing the view of our web-pages you accept the terms of using these files. You can find out more about cookie-files and privacy policy or close the notification, by clicking on the button. Learn More →
Do not show again