Examples of errors detected by the V594 diagnostic


V594. The pointer steps out of array's bounds.


ReactOS

V594 The pointer steps out of array's bounds. ff_dir.c 260


FF_T_WCHAR FileName[FF_MAX_FILENAME];

FF_T_UINT32 FF_FindEntryInDir(....) {
  ....
  FF_T_WCHAR *lastPtr = pDirent->FileName +
                        sizeof(pDirent->FileName);
  ....
  lastPtr[-1] = '\0';
  ....
}

This is what should have been written here: FF_T_WCHAR *lastPtr = pDirent->FileName + sizeof(pDirent->FileName) / sizeof(pDirent->FileName[0]);



Bugs Found

Checked Projects
344
Collected Errors
12 970