Examples of errors detected by the V631 diagnostic.


V631. Consider inspecting the 'Foo' function call. Defining an absolute path to the file or directory is considered a poor style.


ffdshow

V631 Consider inspecting the 'fopen' function call. Defining an absolute path to the file or directory is considered a poor style. writersink.cpp 13


STDMETHODIMP TmyWriterSink::OnHeader(INSSBuffer *pHeader)
{
  if (!f) f=fopen("c:\\2.wmv","wb");
  BYTE *buf; DWORD len;
  pHeader->GetBufferAndLength(&buf,&len;);
  fwrite(buf,1,len,f);
  return S_OK;
}

Even if this was written just for the purpose of debugging, you'd better not do it that way. Other programmers may have troubles working with it.


NetXMS

V631 Consider inspecting the 'CreateFileW' function call. Defining an absolute path to the file or directory is considered a poor style. netxmsd.cpp 126


static void CreateMiniDump(DWORD pid)
{
  ....
  hFile = CreateFile(
    _T("C:\\netxmsd.mdmp"), GENERIC_WRITE, 0, NULL,
    CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);

  ....
}

VirtualDub

V631 Consider inspecting the 'LoadLibraryA' function call. Defining an absolute path to the file or directory is considered a poor style. VirtualDub leaks.cpp 67

V631 Consider inspecting the 'LoadLibraryA' function call. Defining an absolute path to the file or directory is considered a poor style. VirtualDub leaks.cpp 69


VDDbgHelpDynamicLoaderW32::VDDbgHelpDynamicLoaderW32()
{
  hmodDbgHelp = LoadLibrary(
    "c:\\program files\\debugging tools for windows\\dbghelp");
  if (!hmodDbgHelp) {
    hmodDbgHelp = LoadLibrary("c:\\program files (x86)\\......
  ....
}


Do you make errors in the code?

Check your code
with PVS-Studio

Static code analysis
for C, C++, and C#

goto PVS-Studio;
We use cookies for the analysis of events to improve our content and make user interaction more convenient. By continuing the view of our web-pages you accept the terms of using these files. You can find out more about cookie-files and privacy policy or close the notification, by clicking on the button. Learn More →
Do not show again