Rus
  1. HOME
  2. EXAMPLES OF ERRORS

Examples of errors detected by the V676 diagnostic.


V676. It is incorrect to compare the variable of BOOL type with TRUE.

VirtualDub

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'ChooseColorA(& cc) != FALSE'. VirtualDub gui.cpp 665


bool guiChooseColor(HWND hwnd, COLORREF& rgbOld) {
  ....
  if (ChooseColor(&cc)==TRUE) {;
    rgbOld = cc.rgbResult;
    return true;
  }
  ....
}

If the user clicks the OK button of the dialog box, the return value is **nonzero**.

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'ChooseColorA(& cc) != FALSE'. VDFilters vfrotate2.cpp 54

Firebird

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'success == FALSE'. iscguard.cpp 667


THREAD_ENTRY_DECLARE start_and_watch_server(THREAD_ENTRY_PARAM)
{
  ....
  success = CreateProcess(....);
  if (success != TRUE)
    error = GetLastError();
  ....
}

#info If the function succeeds, the return value is nonzero.

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'success == FALSE'. iscguard.cpp 691
  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: '(* m_funct)(lpCS) != FALSE'. locks.h 64
  • V676 It is incorrect to compare the variable of BOOL type with TRUE. iscguard.cpp 614
  • And 2 additional diagnostic messages.

CryEngine 3 SDK

V676 It is incorrect to compare the variable of BOOL type with TRUE. statsagentpipe.cpp 163


bool CStatsAgentPipe::Send()
{
  ....
  ok = ::WriteFile(s_pipe, pBuffer.c_str(), nBytes, &tx, 0)
       == TRUE;
  ....
}

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. statsagentpipe.cpp 108

Apple II emulator

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'out != FALSE'. frame.cpp 381


typedef int BOOL;

static void Draw3dRect (...., BOOL out)
{
  ....
  SelectObject(dc,(out == 1) ? btnhighlightpen : btnshadowpen);
  ....
}

Do you make errors in the code?

Check your code
with PVS-Studio

Static code analysis
for C, C++ and C#

goto PVS-Studio;

Bugs Found

Checked Projects
295
Collected Errors
12 964

Qt

C++ 
int gx = gm.x.toInt();
int gy = gm.y.toInt();
int iw = gm.width.toInt();
int ih = gm.height.toInt();
if (iw <= 0 || iw <= 0)
  return 0;

UnrealEngine

C++ 
switch ( BlendMode )
{
case Opaque:
  BackgroundColor.A = 1.0f;
case Masked:
  BackgroundColor.A = 0.0f;
}

Xamarin

C# 
get {
  return Left == 0 &&
         Top == 0 &&
         Right == 0 &&
         Left == 0;
}

Chromium

C++ 
void Explode(bool is_local,
  Exploded* exploded) const
{
  ....
  ZeroMemory(
    exploded,
    sizeof(exploded));
  ....
}

Qt

C++ 
int gx = gm.x.toInt();
int gy = gm.y.toInt();
int iw = gm.width.toInt();
int ih = gm.height.toInt();
if (iw <= 0 || iw <= 0)
  return 0;

UnrealEngine

C++ 
switch ( BlendMode )
{
case Opaque:
  BackgroundColor.A = 1.0f;
case Masked:
  BackgroundColor.A = 0.0f;
}

Xamarin

C# 
get {
  return Left == 0 &&
         Top == 0 &&
         Right == 0 &&
         Left == 0;
}

Chromium

C++ 
void Explode(bool is_local,
  Exploded* exploded) const
{
  ....
  ZeroMemory(
    exploded,
    sizeof(exploded));
  ....
}
All projects →

Recent Posts

All articles →

It's interesting!