The analyzer has detected a suspicious expression that contains an integer division or modulo operation, with the left operand always being less than the right operand. Such an expression will always evaluate to zero.
Consider the following example:
if ( nTotal > 30 && pBadSource->m_nNegativeVotes / nTotal > 2/3 )
{
....
}
Since both literals '2' and '3' are of integer type, the quotient will also be integer and, therefore, zero. It means the expression above is equivalent to the following one:
if ( nTotal > 30 && pBadSource->m_nNegativeVotes / nTotal > 0 )
{
....
}
A correct way to fix this error is to explicitly cast one of the operands to a floating-point type, for example:
if ( nTotal > 30 && pBadSource->m_nNegativeVotes / nTotal >
static_cast<float>(2)/3 )
{
....
}
Or:
if ( nTotal > 30 && pBadSource->m_nNegativeVotes / nTotal > 2.0f/3 )
{
....
}
This diagnostic is classified as:
If you feel like the New Year just came, and you missed the first half of January, then all this ...