V3130. Priority of the '&&' operator is higher than that of the '||' operator. Possible missing parentheses.


The analyzer has detected a potential error: the priority of the '&&' logical operator is higher than that of the '||' operator. Programmers often forget this, which causes the result of a logical expression using these operators to be quite different from what was expected.

Consider the following sample of incorrect code:

if (c == 'l' || c == 'L' && !token.IsKeyword)
{ .... }

The programmer most likely expected that equality of the 'c' variable and the value 'l' or 'L' would be checked first, and only then the '&&' operation would be executed. But according to the C# operator precedence, the '&&' operation is executed first, and only then, the '||' operation.

We recommend that you add parentheses in every expression that contains operators you use rarely, or whenever you're not sure about the priorities. Even if parentheses appear to be unnecessary, it's ok. At the same time, you code will become easier to comprehend and less error-prone.

This is the fixed code:

if ((c == 'l' || c == 'L') && !token.IsKeyword)
{ .... }

How to get rid of a false positive in case it was this very sequence you actually intended: first '&&', then '||'?

There are several ways:

1) Bad way. You may add the "//-V3130" comment into the corresponding line to suppress the warning.

if (c == 'l' || c == 'L' && !token.IsKeyword) //-V3130
{ .... }

2) Good way. You may write additional parentheses:

if (c == 'l' || (c == 'L' && !token.IsKeyword))
{ .... }

These will help other programmers understand that the code is correct.


Bugs Found

Checked Projects
344
Collected Errors
12 970